2019-11-28 18:7:44 (GMT)
I just merged this PR containing years of hard work :tada: :party_ball: .
The release is getting closer!
2019-12-03 9:53:29 (GMT)
Hi Simon!
2019-12-03 9:53:37 (GMT)
I read your email with Sophie
2019-12-03 9:53:59 (GMT)
I thought that once you indent it is over :)
2019-12-03 9:54:4 (GMT)
What exactly should I look at
2019-12-03 14:26:34 (GMT)
At whether you like the indentation or not :p
And whether anything seems weird to you.
2019-12-03 14:26:50 (GMT)
I made a PR so you get the chance to look at it :)
2019-12-03 19:52:54 (GMT)
If you're happy with me, let me know asap, so I can actually release
2019-12-05 15:31:36 (GMT)
Honestly I have no idea about OCaml indentation
2019-12-05 15:31:45 (GMT)
the only thing I worry about is my further changes
2019-12-05 15:32:1 (GMT)
and how to integrate this indentation to my further work
2019-12-05 15:32:5 (GMT)
that is
2019-12-05 15:32:18 (GMT)
would running certain command before each commit be enough?
2019-12-05 15:32:35 (GMT)
tldr; any indentation good for you is good for me :)
2019-12-05 15:35:9 (GMT)
Ah well then I'll merge.
2019-12-05 15:36:3 (GMT)
And of course
2019-12-05 15:36:6 (GMT)
you can try make reindent on your branch as well I imagine, but merging is going to be fun (which is why I said it's better to keep your work in new files as miuch as possible)
2019-12-05 15:36:21 (GMT)
yeah the new work is in new files
2019-12-05 15:36:26 (GMT)
but there were two bugfixes
2019-12-05 15:36:28 (GMT)
in lzip-bool
2019-12-05 15:36:37 (GMT)
that I don't know if you already merged
2019-12-05 15:36:45 (GMT)
those had to be in old files
2019-12-05 15:36:47 (GMT)
I have no idea, i didn't touch lzip-bool after the merge
2019-12-05 15:36:53 (GMT)
as they are about optimized
2019-12-05 15:37:2 (GMT)
application of substitution
2019-12-05 15:37:7 (GMT)
and beta/eta normalization
2019-12-05 15:39:54 (GMT)
ok I see
2019-12-05 15:39:58 (GMT)
the situation now
2019-12-05 15:40:5 (GMT)
make reindent makes huge problems
2019-12-05 15:41:24 (GMT)
wait
2019-12-05 15:41:28 (GMT)
now in lzip-bool
2019-12-05 15:41:36 (GMT)
I can see you merged master into it
2019-12-05 15:41:51 (GMT)
those two changes should be ok then, right?
2019-12-05 15:42:56 (GMT)
that is lzip-bool should be in mergeable state?
2019-12-05 15:57:40 (GMT)
can you avoid writing 3 words per line? :stuck_out_tongue_wink:
I didn't touch lzip-bool, once a branch is merged I generally don't use it anymore.
2019-12-05 15:57:55 (GMT)
if the changes are not in master can you please merge them?
2019-12-05 16:15:33 (GMT)
merged :)
2019-12-05 18:18:27 (GMT)
So, we can release? :heart_eyes:
2019-12-05 20:47:33 (GMT)
https://github.com/ocaml/opam-repository/pull/15459 PR in progress
2019-12-05 20:53:21 (GMT)
Don't hesitate to modify the docs (on gh-pages branch) to add some pointers to papers. Published version at: https://sneeuwballen.github.io/zipperposition/
2019-12-05 20:55:45 (GMT)
https://github.com/sneeuwballen/zipperposition/releases/tag/1.6 for the release itself.